Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quidditch_snitch] Implement barrier operation #53

Merged
merged 1 commit into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions codegen/compiler/src/Quidditch/Conversion/ConvertSnitchToLLVM.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,22 @@ struct L1MemoryViewOpLowering : ConvertOpToLLVMPattern<L1MemoryViewOp> {
return success();
}
};

struct BarrierOpLowering : ConvertOpToLLVMPattern<BarrierOp> {

LLVM::LLVMFuncOp barrierFunc;

BarrierOpLowering(LLVM::LLVMFuncOp barrierFunc,
const LLVMTypeConverter &converter)
: ConvertOpToLLVMPattern(converter), barrierFunc(barrierFunc) {}

LogicalResult
matchAndRewrite(BarrierOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const override {
rewriter.replaceOpWithNewOp<LLVM::CallOp>(op, barrierFunc, ValueRange());
return success();
}
};
} // namespace

void ConvertSnitchToLLVM::runOnOperation() {
Expand All @@ -72,8 +88,19 @@ void ConvertSnitchToLLVM::runOnOperation() {
options.overrideIndexBitwidth(32);
LLVMTypeConverter typeConverter(&getContext(), options, &dataLayoutAnalysis);

auto builder = OpBuilder::atBlockEnd(getOperation().getBody());
auto ptrType = builder.getType<LLVM::LLVMPointerType>();
IntegerType i32 = builder.getI32Type();
IntegerType sizeT = i32;
auto barrier = builder.create<LLVM::LLVMFuncOp>(
builder.getUnknownLoc(), "snrt_cluster_hw_barrier",
LLVM::LLVMFunctionType::get(builder.getType<LLVM::LLVMVoidType>(),
ArrayRef<Type>{}));
barrier->setAttr("hal.import.bitcode", builder.getUnitAttr());

RewritePatternSet patterns(&getContext());
patterns.insert<L1MemoryViewOpLowering>(typeConverter);
patterns.insert<BarrierOpLowering>(barrier, typeConverter);

LLVMConversionTarget target(getContext());
target.markUnknownOpDynamicallyLegal([](auto) { return true; });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,10 @@ def QuidditchSnitch_L1MemoryViewOp : QuidditchSnitch_Op<"l1_memory_view",
}];
}

def QuidditchSnitch_BarrierOp : QuidditchSnitch_Op<"barrier"> {
let assemblyFormat = [{
attr-dict
}];
}

#endif
8 changes: 8 additions & 0 deletions codegen/tests/Conversion/ConvertSnitchToLLVM/barrier.mlir
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// RUN: quidditch-opt %s --quidditch-convert-snitch-to-llvm | FileCheck %s

// CHECK-LABEL: @test
func.func @test() {
// CHECK: call @snrt_cluster_hw_barrier()
quidditch_snitch.barrier
return
}