feat: implement MBA blast algorithm #977
Merged
+5,957
−5,013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alive Statistics: 90 / 93 (3 failed) |
|
Alive Statistics: 90 / 93 (3 failed) |
This taught me an important dependent design principle: Hide the actual 'casting' of environments behind a new definition. This will allow propext to unify things, while writing lemmas about the cast will allow 'simp' to simplify it. Building a raw function will mean that 'simp' is entirely unable to unify terms, since it doesn't see that the 'content' of what's going on is the casting of `Fin n` along an irrelevant proof.
|
Alive Statistics: 90 / 93 (3 failed) |
We next need to write a `Decidable` instance for `forall (env : EnvFin 1 eqn.numVars), eqn.denote env = 0`. This is trivial, since we can brute-force all `EnvFin 1 eqn.numVars`. However, it's not clear how much of the machinery lives in `Mathlib`.
|
Alive Statistics: 90 / 93 (3 failed) |
1 similar comment
|
Alive Statistics: 90 / 93 (3 failed) |
|
Alive Statistics: 90 / 93 (3 failed) |
This made me realize that we really need a CommRing instance, or something like it, to not drive ourselves craxy when dealing with bitvectors.
|
Alive Statistics: 90 / 93 (3 failed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement the MBA-blast theory on terms, which will allow us to decide mixed boolean arithmetic theorems.