Change Write Permission Checking to use an Internal Database Table instead of Firebase Custom Claims. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irebase Custom Claims. Firebase custom claims requires service accounts and generating a private key for management, which may present more of a security risk, and is slightly more cumbersome than just running some SQL statements. I've taken some steps to continue using custom claims but it seems the overhead of conforming to the new security standard of avoiding service account private keys is too onerous. Removing it also means we no longer have to maintain the `grantaccess.go` script. README is updated. Also tested on a manual test deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase custom claims requires service accounts and generating a private key for management, which may present more of a security risk, and is slightly more cumbersome than just running some SQL statements.
I've taken some steps to continue using custom claims but it seems the overhead of conforming to the new security standard of avoiding service account private keys is too onerous. Removing it also means we no longer have to maintain the
grantaccess.goscript.README is updated. Tested by manually deploying and verifying functionalities.