Skip to content

Commit

Permalink
resolving conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
charantejag504 committed Sep 8, 2023
1 parent 0e8da75 commit 049f89c
Show file tree
Hide file tree
Showing 3 changed files with 277 additions and 48 deletions.
63 changes: 57 additions & 6 deletions internal/deviations/deviations.go
Original file line number Diff line number Diff line change
Expand Up @@ -534,12 +534,6 @@ func P4RTGdpRequiresDot1QSubinterface(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetP4RtGdpRequiresDot1QSubinterface()
}

// ATEPortLinkStateOperationsUnsupported returns true for traffic generators that do not support
// port link state control operations (such as port shutdown.)
func ATEPortLinkStateOperationsUnsupported(ate *ondatra.ATEDevice) bool {
return lookupATEDeviations(ate).GetAtePortLinkStateOperationsUnsupported()
}

// ISISLspLifetimeIntervalRequiresLspRefreshInterval returns true for devices that require
// configuring lspRefreshInterval ISIS timer when lspLifetimeInterval is configured.
func ISISLspLifetimeIntervalRequiresLspRefreshInterval(dut *ondatra.DUTDevice) bool {
Expand All @@ -552,6 +546,63 @@ func AggregateLoopbackModeRequiresMemberPortLoopbackMode(dut *ondatra.DUTDevice)
return lookupDUTDeviations(dut).GetAggregateLoopbackModeRequiresMemberPortLoopbackMode()
}

// LinecardCPUUtilizationUnsupported returns if the device does not support telemetry path
// /components/component/cpu/utilization/state/avg for linecards' CPU card.
// Default value is false.
func LinecardCPUUtilizationUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetLinecardCpuUtilizationUnsupported()
}

// ConsistentComponentNamesUnsupported returns if the device does not support consistent component names for GNOI and GNMI.
// Default value is false.
func ConsistentComponentNamesUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetConsistentComponentNamesUnsupported()
}

// ControllerCardCPUUtilizationUnsupported returns if the device does not support telemetry path
// /components/component/cpu/utilization/state/avg for controller cards' CPU card.
// Default value is false.
func ControllerCardCPUUtilizationUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetControllerCardCpuUtilizationUnsupported()
}

// FabricDropCounterUnsupported returns if the device does not support counter for fabric block lost packets.
// Default value is false.
func FabricDropCounterUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetFabricDropCounterUnsupported()
}

// LinecardMemoryUtilizationUnsupported returns if the device does not support memory utilization related leaves for linecard components.
// Default value is false.
func LinecardMemoryUtilizationUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetLinecardMemoryUtilizationUnsupported()
}

// QOSVoqDropCounterUnsupported returns if the device does not support telemetry path
// /qos/interfaces/interface/input/virtual-output-queues/voq-interface/queues/queue/state/dropped-pkts.
// Default value is false.
func QOSVoqDropCounterUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetQosVoqDropCounterUnsupported()
}

// ISISTimersCsnpIntervalUnsupported returns true for devices that do not support
// configuring csnp-interval timer for ISIS.
func ISISTimersCsnpIntervalUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetIsisTimersCsnpIntervalUnsupported()
}

// ISISCounterManualAddressDropFromAreasUnsupported returns true for devices that do not
// support telemetry for isis system-level-counter manual-address-drop-from-areas.
func ISISCounterManualAddressDropFromAreasUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetIsisCounterManualAddressDropFromAreasUnsupported()
}

// ISISCounterPartChangesUnsupported returns true for devices that do not
// support telemetry for isis system-level-counter part-changes.
func ISISCounterPartChangesUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetIsisCounterPartChangesUnsupported()
}

// MatchedPacketsOctetsUnsupported returns true if telemetry path /qos/interfaces/interface/input/classifiers/classifier/terms/term/state/matched-packets and matched-octets is not supported.
func MatchedPacketsOctetsUnsupported(dut *ondatra.DUTDevice) bool {
return lookupDUTDeviations(dut).GetMatchedPacketsOctetsUnsupported()
Expand Down
30 changes: 29 additions & 1 deletion proto/metadata.proto
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,36 @@ message Metadata {
// LoopbackMode on aggregate interface.
// Arista: partnerissuetracker.corp.google.com/297391260
bool aggregate_loopback_mode_requires_member_port_loopback_mode = 97;
// Device does not support telemetry path
// /components/component/cpu/utilization/state/avg for linecards' CPU card.
bool linecard_cpu_utilization_unsupported = 98;
// Device does not support consistent component names for GNOI and GNMI.
bool consistent_component_names_unsupported = 99;
// Device does not support telemetry path
// /components/component/cpu/utilization/state/avg for controller cards'
// CPU card.
bool controller_card_cpu_utilization_unsupported = 100;
// Device does not support counter for fabric block lost packets.
bool fabric_drop_counter_unsupported = 101;
// Device does not support memory utilization related leaves for linecard components.
bool linecard_memory_utilization_unsupported = 102;
// Device does not support telemetry path
// /qos/interfaces/interface/input/virtual-output-queues/voq-interface/queues/queue/state/dropped-pkts.
bool qos_voq_drop_counter_unsupported = 103;
// ATE IPv6 flow label unsupported in KNE/virtualized environments.
bool ate_ipv6_flow_label_unsupported = 104;
// Devices do not support configuring isis csnp-interval timer.
// Arista: partnerissuetracker.corp.google.com/299283216
bool isis_timers_csnp_interval_unsupported = 105;
// Devices do not support telemetry for isis counter:
// manual-address-drop-from-areas.
// Arista: partnerissuetracker.corp.google.com/299285115
bool isis_counter_manual_address_drop_from_areas_unsupported = 106;
// Devices do not support telemetry for isis counter: part-changes.
// Arista: partnerissuetracker.corp.google.com/299285991
bool isis_counter_part_changes_unsupported = 107;
// Device does not support matched-packets and matched-octets state paths.
bool matched_packets_octets_unsupported = 98;
bool matched_packets_octets_unsupported = 108;

// Reserved field numbers and identifiers.
reserved 84, 9, 28;
Expand Down
Loading

0 comments on commit 049f89c

Please sign in to comment.