Adding retry for MED check after config change #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #2394 / 3effe9aVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 10087219277Details
💛 - Coveralls |
Co-authored-by: rszarecki <[email protected]>
* RT-1.33 : BGP Prefix-set initial commit
Following changes in this PR -
1. Adding test script bgp_prefix_set_test.go
2. Adding new deviation skip_prefix_set_mode
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
* Fixing rundata using tools/addrundata
* Management HA Readme * updating git issue * updating the README
* management HA solution test * merged readme
* Cleanup featureprofiles static analysis errors. * added .test file by mistake * fix tests
Co-authored-by: Darren Loher <[email protected]>
* add registry and body * define policy rough draft * try yaml formatting for path list * Defined paths and policies * add expected results * fix comm name * add export policy * Break out config and validation in separate subtests * define accept policy for test environment setup verification Co-authored-by: rszarecki <[email protected]> * revise numbering, break out steps for config vs. validation --------- Co-authored-by: rszarecki <[email protected]>
* ADD a test to verify ZR optic firmware version streaming telemetry
… subtest (openconfig#2804) * Add workaround for Arista * fix go vet error
…ew subtest for PolicyW (openconfig#2648) * Adding deviation for new subtest for PolicyW * add deviation * fix checks * Add deviation for TE-3.7 * Changes for te-3.7 and resolve conflicts * fix conflicts * resolve conflicts --------- Co-authored-by: AmrNJ <[email protected]>
* KNE: migrating configs to grpc_server
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
* added jrpc-server
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
* Add CD test * Add CD test * Revise readme * Revise readme * fix description mismatch * minor update
…#2834) * Arista specific fixes for basic_static_route_support_test * fix flow stats logic
…penconfig#2828) * Fix TE-16.1 basic_encap_test for Arista due to expected deviations Fix the test failures due to the following issues in the test - The test was setting "network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/l2/ethertype" to detect match rule AF for the default rule. But this path should not be used for that and is not supported by EOS. - Add the following deviations for EOS: static_protocol_name: "STATIC" gribi_mac_override_static_arp_static_route: true interface_enabled: true ttl_copy_unsupported: true ( The TTL expectation is wrong in the test. once that is fixed, this can be removed ) default_network_instance: "default" - Add static routes to magic IP and setup a static arp entry for magic ip address with all the egress interfaces for EOS. - Change the publishing of AFT entries such that NH/NHG aft entries are pushed together. The test still fails on validating encapRatio. We need to see if the test has the right flows to validate this. But pushing the fixes for other issues. * Address pramod's comments. --------- Co-authored-by: Pramod Maurya <[email protected]>
* Update qos_policy_config_test ECN Queue config min/max Threshold etc * Update qos_policy_config_test ECN Queue config min/max Threshold etc --------- Co-authored-by: anksaiki <[email protected]> Co-authored-by: rszarecki <[email protected]>
Also remove irrelevant coverage in one of the files that was added.
* FNT nightly failure: Nokia * updated readme * update readme * readme changes --------- Co-authored-by: Ram <[email protected]>
* system_generic_health_check xpath fix * addressed deviation comment and leaf sw change enhancements * addressing merge coflicts * addressing readme static failures * addressing readme static failures * Fixed static failure
…openconfig#3033) * Added stop traffic before getting the traffic flow statistics * Updated README based on new specification --------- Co-authored-by: KandukuriSudheer <[email protected]>
* fix link_bandwidth_test.go * static analysis failure * static analysis fix * static analysis fix * reverting the readme changes * Update deviations.go * Update metadata.pb.go * Update metadata.pb.go * fixing static analysis failure * Update link_bandwidth_test.go * Update link_bandwidth_test.go * Update link_bandwidth_test.go * Update link_bandwidth_test.go
* Include HW name in nosimage.proto * Fix * don't break proto
* reate a Readme file for DP-1.5 Egress Strict Priority scheduler with bursty traffic * Update DP-1.5 Readme
…3133) * -Removal of `explicit_interface_ref_definition` deviation from following metadata.textproto TE-3.31 TE-3.3 TE-3.1 TE-14.2 TE-14.1 "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Updated README.md of TE-3.3 "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Removal of `explicit_interface_ref_definition` deviation from OTG files of TE-3.31 & TE-3.3 "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." * Updated README.md of TE-3.3 under otg_tests "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
* fix link_bandwidth_test * Include HW name in nosimage.proto (openconfig#2947) * Include HW name in nosimage.proto * Fix * don't break proto * fix static analysis * Create a Readme file for DP-1.5 (openconfig#3044) * reate a Readme file for DP-1.5 Egress Strict Priority scheduler with bursty traffic * Update DP-1.5 Readme * fix for deviation and adding AS check for dut AS --------- Co-authored-by: Wen Bo Li <[email protected]> Co-authored-by: ihebboubaker <[email protected]>
* modify power range, update logical chanel config and remove min/max/avg check * Modify README file * Modify README * adding library to properly configure logical channels
…config#3103) * CD test update and add a telemetry deviation * refactor with cfgplugins * update the same for inventory test * remove outdated deviations * add back the necessary deviation * remove invalid value range check * Add log msgs
…3264) * Update testregistry.textproto Add Test# for BGP route-refresh capability * Update testregistry.textproto
* Add README for IPv6 ND suppression.
* modify power range, update logical chanel config and remove min/max/avg check * Modify README file * Modify README * adding library to properly configure logical channels * update in/out power to align with other zr tests * update in/out power README * update in/out power README one more time * update in/out power README one more time * update in/out power README one more time * update in/out power README one more time * update in/out power README one more time * update in/out power README one more time
* add fan_tray type to readme * Add FAN_TRAY type to telemetry_inventory_test.go. * add NumFanTrays arg * skip fan tray telemetry check when 0 are expected * add FAN_TRAY as platform_type to README. * validate that fan tray parent is the chassis. * validate fan component's parent. * Add deviation for fan tray type. * Use fan tray deviation in telemetry_inventory_test. * fix call to FanTrayTypeUnsupported. * Remove switch_chip_id_unsupported from Nokia. * Add arg_num_fans. * Skip fan validation when args_num_fans is 0. * Update args.go * Fix metadata.pb.go. * Fix metadata.pb.go. * Fix deviations.go typo. * Only check that FAN has ancestor chassis, not the immediate parent type. * Fix metadata.pg.go. * FIx metadata.pb.go. * Fix metadata.pb.go. * Remove fan_tray deviation from metadata.proto. * Remove fan_tray deviation from deviations.go. * Remove fan_tray deviation from metadata.textproto. * Update metadata.proto * Remove fan_tray deviation from telemetry_inventory_test.go. * Fix metadata.pb.go. * Fix brackets in telemetry_inventory_test.go.
* Create README for RT-7.6: link bandwidth aggregation.
nsadhasivam
requested changes
Dec 26, 2024
| break checkMEDLoop | ||
| case diff != "" && repeat > 0: | ||
| t.Logf("MED values not as expected , wait for 10 sec before retry. want %v , got %v", wantMED, gotMED) | ||
| time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
Please gnmi.Watch instead of time.sleep
https://github.com/openconfig/ondatra/blob/b07a95699a4eed8aa606762baadc0a96074c4394/gnmi/gnmi.go#L42-L86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."