-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FP-1.1: Power admin DOWN/UP Test #3144
base: main
Are you sure you want to change the base?
Conversation
Pull Request Functional Test Report for #3144 / 9add225Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 9708142970Details
💛 - Coveralls |
feature/platform/tests/power_admin_down_up_test/power_admin_down_up_test.go
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 11080805089Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your objective is
Empty check should be done initially before removable state check.
then you can simply rearrange the two checks in the original code. There's no need to add an extra pair of the identical checks.
Added check for the fabrics which are removable