DP-2.4 Police traffic on input interface matching all packets using 1 rate, 2 color marker. #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding test case for vanilla policier per interface/sub-interface support that exists on vendors today
dplore
requested changes
Aug 19, 2024
Added classifier details for standard bandwidth management.
Pull Request Test Coverage Report for Build 11282194573Details
💛 - Coveralls |
Co-authored-by: Darren Loher <[email protected]>
vishnureddybadveli
changed the title
dplore
requested changes
Aug 20, 2024
LimeHat
reviewed
Aug 21, 2024
dplore
reviewed
Aug 21, 2024
Co-authored-by: Darren Loher <[email protected]>
dplore
changed the title
vishnureddybadveli
changed the title
|
Please refresh the canonical OC for policer configuration to match the style in DP-2.2 (you can of course remove the classifier terms, but please do use the forwarding-groups and queue configuration) |
Changed to DP-2.4 and classifier removal.
vishnureddybadveli
changed the title
Yes refreshed with the canonical OC to match the style in DP-2.2 and removed classifier terms, in order to avoid any confusion as DP-2.2 is still been in the works and to decouple with DP-2.2 I had refrained from using any queue configurations, forwarding-groups. |
dplore
reviewed
Oct 9, 2024
Added validation criteria for packets, specific rate.
dplore
previously approved these changes
Oct 10, 2024
dplore
reviewed
Oct 10, 2024
dplore
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test case for one rate, two color policier matching on input interface/sub-interface.