Accountz-3.1 #3391
Open
Accountz-3.1 #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #3391 / b7b1fd4Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 11132641175Details
💛 - Coveralls |
Closed
dipchauh
added
nokia-pr
new-requirement-pr
…tz3dot1
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
morrowc
reviewed
Sep 11, 2024
| // so... we get what we can get. | ||
| addr := getDutAddr(t, dut) | ||
|
|
||
| // suppose ssh could be not 22 in some cases but don't think this is exposed by introspect |
There was a problem hiding this comment.
and a period at the end of the sentence.
| setupUsers(t, dut) | ||
|
|
||
| // https://github.com/openconfig/featureprofiles/issues/2637 | ||
| // basically, just waiting to see what the "best"/"preferred" way is to get the v4/v6 of the |
There was a problem hiding this comment.
All comments should be in the form of complete and properly punctuated sentences.
…tz3dot1
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
morrowc
reviewed
Sep 22, 2024
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package record_subscribe_non_grpc_test |
There was a problem hiding this comment.
some of the github action stuff (on other PRs in the gnsi / featureprofile tree) are making noise about 'do not use underscores in golang package names' that might happen here, you might consider getting ahead of that.
There was a problem hiding this comment.
Changed package name
internal/security/acctz/acctz.go
Outdated
| var gRPCClientAddr net.Addr | ||
|
|
||
| // Record represents the structure for an acctz record. | ||
| type Record struct { |
There was a problem hiding this comment.
I think I asked about this in a different PR, but why do this? why not just use a []*pb. ?
Using this new struct means you can't easily cmp.Diff() the expeted content and the received content for a proto... Something like:
got := fooReturnsPB()
if diff := cmp.Diff(got, want, cmpoptions.ProtoTransform()); diff != "" {
t.Errorf("got/want mismatch, diff: %v", diff)
}SHOULD do a comparison of the proto bits you got vs what you wanted... and save what looks like ~100 lines of code in the tests where you pull apart all of the protos and records (and 50+ lines where you fill record struct content...)
There was a problem hiding this comment.
Removed record struct & using pb directly for cmp.Diff()
…tz3dot1
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."