Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved tests from experimental to feature #3469

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

self-maurya
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11119333743

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11119090068: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@OpenConfigBot
Copy link

OpenConfigBot commented Sep 27, 2024

Pull Request Functional Test Report for #3469 / ac78ebc

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
8d5682a3 Log
Cisco 8000E status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
0e9487ed Log
Cisco XRd status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
16c0f379 Log
Juniper ncPTX status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
a5023fba Log
Nokia SR Linux status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
603a9c3c Log
Openconfig Lemming status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
80e0fc56 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
Cisco 8808 status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
Juniper PTX10008 status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation
Nokia 7250 IXR-10e status
status
status
status
status
status
status
status
status
status
status
TE-11.3: Backup NHG: Actions
TE-11.21: Backup NHG: Multiple NH with PBF
RT-5.6: Interface Loopback mode
gNMI-1.20: Telemetry: Optics Thresholds
gNMI-1.3: Benchmarking: Drained Configuration Convergence Time
Health-1.1: Generic Health Check
TUN-1.9: GRE inner packet DSCP
TE-11.1: Backup NHG: Single NH
TE-1.2: My Station MAC
gNMI-1.2: Benchmarking: Full Configuration Replace
TUN-1.4: Interface based IPv6 GRE Encapsulation

Help

@self-maurya self-maurya marked this pull request as ready for review September 27, 2024 11:04
@self-maurya self-maurya requested review from ram-mac and a team as code owners September 27, 2024 11:04
@dplore
Copy link
Member

dplore commented Sep 30, 2024

Please also update https://github.com/openconfig/featureprofiles/blob/main/CONTRIBUTING.md to remove the reference to the experimental folder. Thanks!

@ram-mac
Copy link
Contributor

ram-mac commented Oct 1, 2024

@self-maurya i see the feature.textproto is been deleted. Can you add details on why this file is not needed.
Is this textproto added under some other path?

Copy link
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. Is there any reason not to move ALL of the tests out of the experimental folder?

@self-maurya self-maurya merged commit 89ca9a0 into openconfig:main Oct 1, 2024
13 checks passed
@self-maurya self-maurya deleted the exp branch October 1, 2024 17:03
@dplore
Copy link
Member

dplore commented Oct 2, 2024

@self-maurya i see the feature.textproto is been deleted. Can you add details on why this file is not needed. Is this textproto added under some other path?

The README files replace the intent of the feature.textproto files. The feature.textproto files are considered obsolete.

Copy link
Contributor

@Swetha-haridasula Swetha-haridasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants