Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFLOW-1: Configuring sflow collector respective to IPv4 and IPv6 #3471

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

trathod1
Copy link
Contributor

@trathod1 trathod1 commented Sep 27, 2024

Following changes are made -

  1. Removing explicit_interface_in_default_vrf, considering test is using non-default VRF mvrf1 for the interface.
  2. Based on discussion b/290965827, refactoring the sflow collector configurations to be part of respective V4 and V6 test.
  3. Script currently sending only 1M packets and expecting 1 sample with sampling-rate of 1M. This expectation from script may not be in line with sflow feature in general. Accuracy of sflow sampling increases with bigger sampling window. To achieve consistency in sampling results, following changes are done -
    - packetsToSend is updated from 1M to 10M, and ppsRate from 100k to 300k.
    - Considering increase in traffic packets, now script expecting minimum 9 samples (with tolerance) instead of only 1 sample (from 1M traffic packets) earlier.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Following changes are made -
   1. Removing explicit_interface_in_default_vrf, considering test is using non-default VRF mvrf1 for the interface.
   2. Based on discussion b/290965827, refactoring the sflow collector configurations to be part of respective V4 and V6 test.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@OpenConfigBot
Copy link

OpenConfigBot commented Sep 27, 2024

Pull Request Functional Test Report for #3471 / 37477a5

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
SFLOW-1: sFlow Configuration and Sampling
2bc3988c Log
Cisco 8000E status
SFLOW-1: sFlow Configuration and Sampling
17199460 Log
Cisco XRd status
SFLOW-1: sFlow Configuration and Sampling
b3ec553c Log
Juniper ncPTX status
SFLOW-1: sFlow Configuration and Sampling
937f7462 Log
Nokia SR Linux status
SFLOW-1: sFlow Configuration and Sampling
e823f21b Log
Openconfig Lemming status
SFLOW-1: sFlow Configuration and Sampling
9bbb07f9 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
SFLOW-1: sFlow Configuration and Sampling
Cisco 8808 status
SFLOW-1: sFlow Configuration and Sampling
Juniper PTX10008 status
SFLOW-1: sFlow Configuration and Sampling
Nokia 7250 IXR-10e status
SFLOW-1: sFlow Configuration and Sampling

Help

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11390242358

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11379494154: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

trathod1 and others added 2 commits October 17, 2024 13:42
generation.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@trathod1 trathod1 marked this pull request as ready for review October 17, 2024 20:20
@trathod1 trathod1 requested a review from a team as a code owner October 17, 2024 20:20
@dplore
Copy link
Member

dplore commented Oct 18, 2024

/fptest virtual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants