Implementation of remaining containerz tests. #3477
Conversation
Pull Request Functional Test Report for #3477 / f407f27Virtual Devices
Hardware Devices
|
| ## CNTR-1.6: Upgrade a container on the DUT. | ||
|
|
||
| Using the same container started as part of CNTR-1.1, validate that the container | ||
| can upgraded. |
There was a problem hiding this comment.
| can upgraded. | |
| can be upgraded. |
| ## CNTR-1.6: Upgrade a container on the DUT. | ||
|
|
||
| Using the same container started as part of CNTR-1.1, validate that the container | ||
| can upgraded. |
There was a problem hiding this comment.
Consider adding something that defines what "upgraded" means?
| if err != nil { | ||
| t.Fatalf("unable to start container: %v", err) | ||
| } | ||
|
|
||
| // wait for cntr container to come up. | ||
| time.Sleep(5 * time.Second) |
There was a problem hiding this comment.
I presume there's nothing fancier we can do to determine whether this container is alive? Is this the one that implements ping such that the service can be checked -- or should we consider this a wider integration test?
| } | ||
| } | ||
|
|
||
| if len(logs) == 0 { |
There was a problem hiding this comment.
I presume that the container here is specified to create some logs so there's no chance that this is a flake?
| } | ||
| } | ||
|
|
||
| func TestVolumes(t *testing.T) { |
There was a problem hiding this comment.
Can you add a comment here? I think it'd be worth just noting that the test here ensures that a volume can be created and removed from an API perspective -- it doesn't check that it's possible to actually use that volume.
| } | ||
| } | ||
|
|
||
| _, err = cli.UpdateContainer(ctx, "cntrsrv", "upgrade", "./cntrsrv", instanceName, false, client.WithPorts([]string{"60061:60061"})) |
There was a problem hiding this comment.
| _, err = cli.UpdateContainer(ctx, "cntrsrv", "upgrade", "./cntrsrv", instanceName, false, client.WithPorts([]string{"60061:60061"})) | |
| if _, err = cli.UpdateContainer(ctx, "cntrsrv", "upgrade", "./cntrsrv", instanceName, false, client.WithPorts([]string{"60061:60061"})); err != nil { ... } |
This commit introduces the following tests:
CNTR-1.2
CNTR-1.3
CNTR-1.4
CNTR-1.5
CNTR-1.6