-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create README.md #3495
Create README.md #3495
Conversation
Adding README for RT-3.33: DSCP based traffic steering from Non-default VRF to Default VRF using Policy based VRF selection
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one needs some work -- it's not clear to me that the test logic is sound and that the requirements are clear in it.
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
* IPv4Prefix4/24 to IPv4Prefix9/24 [DSCP:AF3] | ||
* IPv6Prefix4/64 to IPv6Prefix9/64 [DSCP:AF3] | ||
* IPv4Prefix5/24 to IPv4Prefix10/24 [DSCP:AF4] | ||
* IPv6Prefix5/64 to IPv6Prefix10/64 [DSCP:AF4] br><br><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rogue br>
and you can remove the <br>
throughout.
* IPv6Prefix5/64 to IPv6Prefix10/64 [DSCP:AF4] br><br><br> | ||
|
||
|
||
### Following Health checks to be run Pre and Post every sub test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as elsewhere -- please can we define common health checks if they are required.
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
Updated the README to accept the ipv4 & ipv6 native flows with policy based traffic steering.
Updated the test case numbers.
Hello Rob , I had to change the complete test , verified it . Can you please share your feedback ? |
Updated the TC number to PF-1.6.x
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 11257853416Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Updated all the suggested changes and resolved the comments .
Creating the README in appropriate folder for VRF , this is overriding previous pull request openconfig#3495
Hello Team, I am closing this pull request as i created a new one #3510 in the appropriate folder. |
Adding README for RT-3.33: DSCP based traffic steering from Non-default VRF to Default VRF using Policy based VRF selection