Create README.md #3495
Closed
Create README.md #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding README for RT-3.33: DSCP based traffic steering from Non-default VRF to Default VRF using Policy based VRF selection
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
robshakir
requested changes
Oct 3, 2024
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
| * IPv4Prefix4/24 to IPv4Prefix9/24 [DSCP:AF3] | ||
| * IPv6Prefix4/64 to IPv6Prefix9/64 [DSCP:AF3] | ||
| * IPv4Prefix5/24 to IPv4Prefix10/24 [DSCP:AF4] | ||
| * IPv6Prefix5/64 to IPv6Prefix10/64 [DSCP:AF4] br><br><br> |
There was a problem hiding this comment.
Rogue br> and you can remove the <br> throughout.
| * IPv6Prefix5/64 to IPv6Prefix10/64 [DSCP:AF4] br><br><br> | ||
|
|
||
|
|
||
| ### Following Health checks to be run Pre and Post every sub test |
There was a problem hiding this comment.
Same comment as elsewhere -- please can we define common health checks if they are required.
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
Updated the README to accept the ipv4 & ipv6 native flows with policy based traffic steering.
Updated the test case numbers.
|
Hello Rob , I had to change the complete test , verified it . Can you please share your feedback ? |
Updated the TC number to PF-1.6.x
dplore
reviewed
Oct 10, 2024
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
...policy_vrf_selection/otg_tests/policy_based_traffic_steering_default_to_nondefault/README.md
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 11257853416Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Updated all the suggested changes and resolved the comments .
vvlakshmanamurthy
added a commit
to vvlakshmanamurthy/featureprofiles
that referenced
this pull request
Oct 10, 2024
Creating the README in appropriate folder for VRF , this is overriding previous pull request openconfig#3495
|
Hello Team, I am closing this pull request as i created a new one #3510 in the appropriate folder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding README for RT-3.33: DSCP based traffic steering from Non-default VRF to Default VRF using Policy based VRF selection