Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deviation for leaf constraint #3524

Merged
merged 17 commits into from
Oct 18, 2024
Merged

Conversation

ram-mac
Copy link
Contributor

@ram-mac ram-mac commented Oct 18, 2024

power_admin_down_up_test is failing due to below error;
"Leaf 'name' inside the 'config' container must also be set to value '0/FC0' to satisfy the leafref constraint on the list key"

This error is for Leaf-ref validation for list keys which is enforced in XR, and this is fixed by setting the leaf in config container as well. While all other vendors work without this explicit configuration.

So there is deviation to track the behavior separately.

@ram-mac ram-mac requested review from amrindrr and a team as code owners October 18, 2024 06:27
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 18, 2024

Pull Request Functional Test Report for #3524 / 416a818

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
FP-1.1: Power admin DOWN/UP Test
67739bd6 Log
Cisco 8000E status
FP-1.1: Power admin DOWN/UP Test
fecee8a4 Log
Cisco XRd status
FP-1.1: Power admin DOWN/UP Test
14fcfd47 Log
Juniper ncPTX status
FP-1.1: Power admin DOWN/UP Test
a9339a07 Log
Nokia SR Linux status
FP-1.1: Power admin DOWN/UP Test
c6e6520c Log
Openconfig Lemming status
FP-1.1: Power admin DOWN/UP Test
488ff843 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
FP-1.1: Power admin DOWN/UP Test
Cisco 8808 status
FP-1.1: Power admin DOWN/UP Test
Juniper PTX10008 status
FP-1.1: Power admin DOWN/UP Test
Nokia 7250 IXR-10e status
FP-1.1: Power admin DOWN/UP Test

Help

@coveralls
Copy link

coveralls commented Oct 18, 2024

Pull Request Test Coverage Report for Build 11400955655

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11400099174: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@ram-mac ram-mac requested a review from dplore October 18, 2024 08:46
Copy link
Contributor

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ram-mac ram-mac merged commit b251e5e into openconfig:main Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants