Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gNOI-3.4: fix gnoi path for component and reboot status with empty subcomponent #717

Merged
merged 8 commits into from
Nov 16, 2022
Merged

gNOI-3.4: fix gnoi path for component and reboot status with empty subcomponent #717

merged 8 commits into from
Nov 16, 2022

Conversation

mojiiba
Copy link
Contributor

@mojiiba mojiiba commented Oct 29, 2022

This pull adds two deviations and change the gNOI-3.4 accordingly.

  • GNOISubcomponentPath: based on the GNOI spec we need to use path to refer to sub-components. However, the existing tests only uses a path with a single element and no key to refer to sub-component. IMO, this does not seem to be complied with the spec. This deviation will allow us to use fully OC complied path for the component.
  • GNOIStatusWithEmptySubcomponent: as discussed RebootStatus RPC ambiguity gnoi#54 and Update Reboot proto gnoi#99, the gNOI reboot status command response is singular value and therefore it is not clear what the device should reply to a status command when the subcomponent is not set and there are more than one active reboot.

@mojiiba mojiiba requested a review from a team as a code owner October 29, 2022 06:03
@mojiiba mojiiba requested a review from sezhang2 October 29, 2022 06:03
@mojiiba mojiiba changed the title gNOI-3.4: fix gnoi path for component and reboot status with nil subcomponent gNOI-3.4: fix gnoi path for component and reboot status with empty subcomponent Oct 29, 2022
@coveralls
Copy link

coveralls commented Oct 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3459366138

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 73.151%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/components/components.go 0 13 0.0%
Totals Coverage Status
Change from base Build 3447714285: -0.4%
Covered Lines: 1602
Relevant Lines: 2190
💛 - Coveralls

@sezhang2
Copy link
Contributor

/gcbrun

sezhang2
sezhang2 previously approved these changes Nov 14, 2022
View reviewed changes
@sezhang2
Copy link
Contributor

Please re-sync your code to resolve the conflict.

@mojiiba
Copy link
Contributor Author

mojiiba commented Nov 14, 2022

Please re-sync your code to resolve the conflict.

thanks, done

@mojiiba
Copy link
Contributor Author

mojiiba commented Nov 16, 2022

@sezhang2 can u please merge this pr?

@sezhang2
Copy link
Contributor

/gcbrun

@sezhang2
Copy link
Contributor

@sezhang2 can u please merge this pr?

Will merge after all checks pass.

@sezhang2 sezhang2 merged commit ddd53d5 into openconfig:main Nov 16, 2022
@mojiiba
Copy link
Contributor Author

mojiiba commented Nov 16, 2022

@sezhang2 can u please merge this pr?

Will merge after all checks pass.

thanks a lot!

Hobbydos pushed a commit to Hobbydos/featureprofiles that referenced this pull request Nov 17, 2022
@mojiiba @Hobbydos
gNOI-3.4: fix gnoi path for component and reboot status with empty su…
7429eb7 
…bcomponent (openconfig#717)

* add InterfaceOperStatus deviation

* Revert "add InterfaceOperStatus deviation"

This reverts commit f9855b4.

* status test is passing

* fix gnoi path and subcomponent name for reboot status
@mojiiba mojiiba mentioned this pull request Dec 7, 2022
Merged
singh-prem pushed a commit to mingyangcisco/featureprofiles that referenced this pull request Dec 13, 2022
@mojiiba @singh-prem
gNOI-3.4: fix gnoi path for component and reboot status with empty su…
6e0223e 
…bcomponent (openconfig#717)

* add InterfaceOperStatus deviation

* Revert "add InterfaceOperStatus deviation"

This reverts commit f9855b4.

* status test is passing

* fix gnoi path and subcomponent name for reboot status
prinikasn pushed a commit that referenced this pull request Jun 30, 2023
@mojiiba
gNOI-3.4: fix gnoi path for component and reboot status with empty su…
cf07b71 
…bcomponent (#717)

* add InterfaceOperStatus deviation

* Revert "add InterfaceOperStatus deviation"

This reverts commit f9855b4.

* status test is passing

* fix gnoi path and subcomponent name for reboot status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezhang2 sezhang2 sezhang2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mojiiba @coveralls @sezhang2