Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CommitSetRollbackDuration action for Commit Confirmed extension #164

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

hellt
Copy link
Contributor

@hellt hellt commented Jan 9, 2024

This is an alternative version to #161.
In this version, a specific action is added to denote the Set Rollback Duration for the Commit Confirmed action.

@hellt
Copy link
Contributor Author

hellt commented Jan 25, 2024

@kidiyoor @dplore
Hi gentlemen; I wonder how do we proceed with this one?
I am fine with following the @kidiyoor suggestion and moving on with the separate action (which is the case expressed in this PR)

@kidiyoor
Copy link
Contributor

@hellt
Copy link
Contributor Author

hellt commented Jan 26, 2024

@dplore
Copy link
Member

dplore commented Feb 2, 2024

This is a last call for comments. This is planned to merge on Feb 15, 2024.

dplore
dplore previously approved these changes Feb 2, 2024
@hellt
Copy link
Contributor Author

hellt commented Feb 14, 2024

@dplore @kidiyoor with the recent commit I added generated stubs for Go and Py so that we can add this functionality to openconfig/gnmic client.

@hellt
Copy link
Contributor Author

hellt commented Feb 22, 2024

Hi @dplore
The planned merge date was on Feb 15. Is anything left that is gating this?

@dplore dplore merged commit 255e855 into openconfig:master Feb 23, 2024
1 check passed
@dplore
Copy link
Member

dplore commented Feb 23, 2024

Hi @dplore The planned merge date was on Feb 15. Is anything left that is gating this?

Thanks for the ping!

@robshakir
Copy link
Contributor

This should have been merged upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants