Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event watcher for topo create #399

Merged
merged 11 commits into from
Jul 25, 2023
Merged

Event watcher for topo create #399

merged 11 commits into from
Jul 25, 2023

Conversation

NehaManjunath
Copy link
Collaborator

Initial check-in

@NehaManjunath NehaManjunath marked this pull request as draft July 13, 2023 15:45
@coveralls
Copy link

coveralls commented Jul 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5659007399

  • 150 of 153 (98.04%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 65.625%
Changes Missing Coverage Covered Lines Changed/Added Lines %
topo/topo.go 8 11 72.73%
Totals Coverage Status
Change from base Build 5548009281: 0.9%
Covered Lines: 3906
Relevant Lines: 5952
💛 - Coveralls

alexmasi
alexmasi reviewed Jul 17, 2023
View reviewed changes
events/status.go Outdated Show resolved Hide resolved
@NehaManjunath NehaManjunath marked this pull request as ready for review July 19, 2023 17:01
alexmasi
alexmasi reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@alexmasi alexmasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix all linter issues

events/status.go Outdated Show resolved Hide resolved
events/status.go Outdated Show resolved Hide resolved
events/events.go Outdated Show resolved Hide resolved
events/events.go Show resolved Hide resolved
bormanp
bormanp reviewed Jul 24, 2023
View reviewed changes
events/events.go Outdated Show resolved Hide resolved
events/events.go Show resolved Hide resolved
events/events.go Outdated Show resolved Hide resolved
events/status.go Outdated Show resolved Hide resolved
events/status.go Outdated Show resolved Hide resolved
bormanp
bormanp reviewed Jul 25, 2023
View reviewed changes
events/data_test.go Outdated Show resolved Hide resolved
@NehaManjunath NehaManjunath merged commit 5e62e6b into main Jul 25, 2023
6 checks passed
@alexmasi alexmasi deleted the event-watcher branch October 6, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmasi alexmasi alexmasi left review comments

@bormanp bormanp bormanp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NehaManjunath @coveralls @alexmasi @bormanp