juniper config mode retry and error handling #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare occasions, getting into config mode can take some time. Change here adds retry in case of privilege error by Scrapligo. Scrapligo throws this when config mode is not yet available. Also adds a bit better error handling and printing pod information when certificate push failure occurs. Also gets rid of /sys/class mount which is no longer needed.
|
/gcbrun |
alexmasi
reviewed
Aug 22, 2023
Also covers a commit failure case. Both part of certificate generation.
alexmasi
reviewed
Aug 22, 2023
|
/gcbrun |
alexmasi
approved these changes
Aug 22, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare occasions, getting into config mode can take some time. Change here adds retry in case of privilege error by Scrapligo. Scrapligo throws this when config mode is not yet available. Also adds a bit better error handling and printing pod information when certificate push failure occurs.
Also gets rid of /sys/class mount which is no longer needed.