Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve packet logging #216

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Improve packet logging #216

merged 7 commits into from
Jul 13, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Jul 11, 2023 •
edited
Loading

  • golang/mock is deprecated -> replaced with uber fork and regenerated mocks
  • update packet logging API to support log levels
    • Now a level 1: only input and output is logged
    • At level 3: full packet trace is logged
  • Minor fixes the presubmit code

@DanG100 DanG100 requested a review from wenovus July 13, 2023 00:01
@DanG100 DanG100 marked this pull request as ready for review July 13, 2023 00:02
@DanG100 DanG100 changed the title Fix wait fp tests Improve packet logging Jul 13, 2023
wenovus
wenovus reviewed Jul 13, 2023
View reviewed changes
dataplane/forwarding/fwdaction/actions/mirror.go Show resolved Hide resolved
dataplane/forwarding/fwdport/port.go Outdated Show resolved Hide resolved
dataplane/forwarding/fwdport/port.go Show resolved Hide resolved
dataplane/forwarding/fwdport/ports/group.go Show resolved Hide resolved
dataplane/forwarding/protocol/packet.go Show resolved Hide resolved
dataplane/forwarding/protocol/packet.go Outdated Show resolved Hide resolved
@DanG100 DanG100 requested a review from wenovus July 13, 2023 19:57
@DanG100 DanG100 merged commit e902ff1 into main Jul 13, 2023
7 of 8 checks passed
@DanG100 DanG100 deleted the fix-wait branch July 13, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @wenovus