Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial protobuf generator for SAI #218

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Initial protobuf generator for SAI #218

merged 6 commits into from
Jul 28, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Jul 27, 2023 •
edited
Loading

  • Support for parsing SAI doxygen xml
  • Initial templates and generation logic

Note: this is just part1

  • Some types are not yet generated. (enums, compound types_
  • RPCs will be need to handle object ids.

@DanG100 DanG100 requested a review from wenovus July 27, 2023 23:07
@github-actions
Copy link

github-actions bot commented Jul 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5696614495

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.491%
Totals Coverage Status
Change from base Build 5671000775: 0.0%
Covered Lines: 13166
Relevant Lines: 528619
💛 - Coveralls

wenovus
wenovus reviewed Jul 28, 2023
View reviewed changes
dataplane/standalone/apigen/xml.go Show resolved Hide resolved
dataplane/standalone/apigen/xml.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/xml.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/xml.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/apigen.go Show resolved Hide resolved
dataplane/standalone/apigen/apigen.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/apigen.go Show resolved Hide resolved
@DanG100 DanG100 requested a review from wenovus July 28, 2023 19:46
wenovus
wenovus approved these changes Jul 28, 2023
View reviewed changes
dataplane/standalone/apigen/xml.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/xml.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/apigen.go Show resolved Hide resolved
dataplane/standalone/apigen/apigen.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/apigen.go Show resolved Hide resolved
@DanG100 DanG100 merged commit 53493be into main Jul 28, 2023
6 of 8 checks passed
@DanG100 DanG100 deleted the proto-gen-part1 branch July 28, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @wenovus