Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to proto generator #219

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Improvements to proto generator #219

merged 3 commits into from
Jul 31, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Jul 31, 2023

  • Split code in 3 files:

    • apigen: parses the ast and built the struct
    • protogen: generates proto code
    • ccgen: generates cc code

  • generated all enum types

  • hand crafted structs for complex types

@DanG100 DanG100 marked this pull request as ready for review July 31, 2023 21:32
@DanG100 DanG100 requested a review from wenovus July 31, 2023 21:40
@DanG100 DanG100 changed the title Improvement proto generator Improvements to proto generator Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5720422657

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 2.492%
Files with Coverage Reduction New Missed Lines %
gnmi/oc/networkinstance/networkinstance-0.go 3 0.27%
Totals Coverage Status
Change from base Build 5696712431: 0.001%
Covered Lines: 13171
Relevant Lines: 528619
💛 - Coveralls

wenovus
wenovus approved these changes Jul 31, 2023
View reviewed changes
dataplane/standalone/apigen/xml.go Show resolved Hide resolved
dataplane/standalone/apigen/protogen.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/ccgen.go Outdated Show resolved Hide resolved
@DanG100 DanG100 merged commit 379733b into main Jul 31, 2023
7 of 8 checks passed
@DanG100 DanG100 deleted the proto-gen-part2 branch July 31, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @wenovus