Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lemming buildable on non-Linux envs #229

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Make lemming buildable on non-Linux envs #229

merged 5 commits into from
Aug 15, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Aug 14, 2023

This is just a quick fix, I'd like to take a deeper look on the possibility of still being to run the dataplane on not linux

@DanG100 DanG100 requested a review from wenovus August 14, 2023 23:53
Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks neat that we're able to separate out the linux-only interface manager such that it's not compiled unless we're on a linux machine.

dataplane/reconcilers_nonlinux.go Show resolved Hide resolved
@DanG100 DanG100 requested a review from wenovus August 15, 2023 21:39
lemming.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Pull Request Test Coverage Report for Build 5872545144

  • 0 of 28 (0.0%) changed or added relevant lines in 5 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 2.499%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/internal/engine/engine.go 0 1 0.0%
dataplane/server.go 0 1 0.0%
dataplane/reconcilers_linux.go 0 3 0.0%
lemming.go 0 3 0.0%
dataplane/internal/engine/engine_linux.go 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
gnmi/oc/networkinstance/networkinstance-0.go 3 0.27%
dataplane/internal/kernel/kerneltest/kernel.go 8 72.6%
Totals Coverage Status
Change from base Build 5857578806: -0.002%
Covered Lines: 13212
Relevant Lines: 528743

💛 - Coveralls

@DanG100 DanG100 merged commit 4a83fbb into main Aug 15, 2023
6 of 8 checks passed
@DanG100 DanG100 deleted the kernel-nonlinux branch August 15, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants