-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use preemptible VMs for presubmit + other fixes #230
Conversation
Pull Request Test Coverage Report for Build 5872907818
💛 - Coveralls |
size = "medium", | ||
size = "large", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think local_tests still counts as a medium since it runs for a few minutes right now. I also think this should be run as part of GitHub Actions rather than on cloudbuild. Perhaps add another workflow job that runs the medium jobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the local test has been flaky on the github action runner, i want to see if solves the issue https://github.com/openconfig/lemming/actions/runs/5860193044/job/15887753577
https://github.com/openconfig/lemming/actions/runs/5686228980/job/15412660877
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok LGTM
make load
was working as expected