Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use preemptible VMs for presubmit + other fixes #230

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Aug 15, 2023

  • Using not preemptible should help reduce flakiness
  • The local test is unstable to github actions so run it on cloudbuild
  • I'm not that make load was working as expected

@DanG100 DanG100 changed the title Don't use prempible VMs for presubmit Don't use premptible VMs for presubmit Aug 15, 2023
@DanG100 DanG100 changed the title Don't use premptible VMs for presubmit Don't use preemptible VMs for presubmit Aug 15, 2023
@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Pull Request Test Coverage Report for Build 5872907818

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 306 unchanged lines in 9 files lost coverage.
  • Overall coverage remained the same at 2.499%

Files with Coverage Reduction New Missed Lines %
gnmi/oc/networkinstance/networkinstance-0.go 3 0.27%
dataplane/internal/kernel/kerneltest/kernel.go 10 72.6%
dataplane/server.go 11 0%
dataplane/internal/kernel/kernel.go 22 0%
dataplane/forwarding/fwdport/ports/kernel.go 25 7.62%
dataplane/forwarding/fwdport/ports/tap.go 32 1.8%
lemming.go 46 70.64%
dataplane/handlers/interface.go 62 0%
dataplane/internal/engine/engine.go 95 0%
Totals Coverage Status
Change from base Build 5869943441: 0.0%
Covered Lines: 13212
Relevant Lines: 528743

💛 - Coveralls

@DanG100 DanG100 changed the title Don't use preemptible VMs for presubmit Don't use preemptible VMs for presubmit + other fixes Aug 16, 2023
size = "medium",
size = "large",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think local_tests still counts as a medium since it runs for a few minutes right now. I also think this should be run as part of GitHub Actions rather than on cloudbuild. Perhaps add another workflow job that runs the medium jobs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok LGTM

@DanG100 DanG100 merged commit 3dd319b into main Aug 17, 2023
8 checks passed
@DanG100 DanG100 deleted the non-prempt branch August 17, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants