Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generation to support bulk APIs #277

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Code generation to support bulk APIs #277

merged 7 commits into from
Sep 28, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Sep 27, 2023 •
edited
Loading

  • Support bulk_create
  • Support enum values that are assign to custom values
  • Support setting the hostif name separately

@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6341809162

  • 9 of 44 (20.45%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 1.973%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/standalone/apigen/protogen/protogen.go 5 19 26.32%
dataplane/standalone/apigen/docparser/docparser.go 0 21 0.0%
Totals Coverage Status
Change from base Build 6306136177: 0.002%
Covered Lines: 12157
Relevant Lines: 616201
💛 - Coveralls

wenovus
wenovus approved these changes Sep 27, 2023
View reviewed changes
dataplane/standalone/apigen/ccgen/ccgen.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/ccgen/ccgen.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/docparser/docparser.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/docparser/docparser.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/saiast/saiast.go Show resolved Hide resolved
@DanG100 DanG100 merged commit 442f947 into main Sep 28, 2023
9 of 10 checks passed
@DanG100 DanG100 deleted the misc-sai branch September 28, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @wenovus