Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate more default values for switch and port #280

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Populate more default values for switch and port #280

merged 2 commits into from
Sep 29, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Sep 28, 2023

  • include the bulk_next_hop from a more recent sai release

@github-actions
Copy link

Pull Request Test Coverage Report for Build 6344177866

  • 223 of 245 (91.02%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 2.004%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/standalone/saiserver/saiserver.go 0 2 0.0%
dataplane/standalone/saiserver/routing.go 56 76 73.68%
Files with Coverage Reduction New Missed Lines %
dataplane/standalone/saiserver/routing.go 2 82.45%
Totals Coverage Status
Change from base Build 6343601684: 0.03%
Covered Lines: 12355
Relevant Lines: 616432
💛 - Coveralls

@DanG100 DanG100 merged commit 7a9a599 into main Sep 29, 2023
11 checks passed
@DanG100 DanG100 deleted the misc-sai3 branch September 29, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @wenovus