Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate applied state for BGP #282

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Populate applied state for BGP #282

merged 1 commit into from
Oct 2, 2023

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Oct 2, 2023

Aside from RoutingPolicy since unsupported leaves will be populated as well. Added TODO for it.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Pull Request Test Coverage Report for Build 6384998263

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • 88 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 2.101%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bgp/gobgp.go 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
bgp/gobgp.go 1 47.69%
gnmi/oc/structs-3.go 7 0.33%
gnmi/oc/structs-2.go 80 0.18%
Totals Coverage Status
Change from base Build 6357149920: -0.01%
Covered Lines: 13034
Relevant Lines: 620387
💛 - Coveralls

@wenovus wenovus requested a review from DanG100 October 2, 2023 20:57
@wenovus wenovus merged commit 07a2d40 into main Oct 2, 2023
9 checks passed
@wenovus wenovus deleted the populate-applied-apply-policy branch October 2, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenovus @DanG100