Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dataplane reset #283

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Implement dataplane reset #283

merged 4 commits into from
Oct 3, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Oct 2, 2023 •
edited
Loading

  • Implement timeouts of packet io, so they close correctly
  • Add reset to engine and sai API

@DanG100 DanG100 requested a review from wenovus October 2, 2023 20:32
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Pull Request Test Coverage Report for Build 6385583876

  • 0 of 151 (0.0%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 2.115%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/standalone/saiserver/attrmgr/attrmgr.go 0 8 0.0%
dataplane/standalone/saiserver/saiserver.go 0 16 0.0%
dataplane/internal/engine/engine_linux.go 0 18 0.0%
dataplane/forwarding/fwdport/ports/kernel.go 0 19 0.0%
dataplane/internal/engine/engine.go 0 41 0.0%
dataplane/forwarding/fwdport/ports/tap.go 0 49 0.0%
Files with Coverage Reduction New Missed Lines %
dataplane/forwarding/fwdport/ports/kernel.go 1 7.34%
Totals Coverage Status
Change from base Build 6357149920: 0.001%
Covered Lines: 13122
Relevant Lines: 620450
💛 - Coveralls

wenovus
wenovus approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will you test this change?

dataplane/standalone/proto/common.proto Show resolved Hide resolved
@DanG100
Copy link
Collaborator Author

DanG100 commented Oct 2, 2023

How will you test this change?

I have task to for an integration test for this to do later

@DanG100 DanG100 merged commit 48c0f9c into main Oct 3, 2023
11 checks passed
@DanG100 DanG100 deleted the dplane-reset branch October 3, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @wenovus