Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the removal of NextHopGroup and NextHopGroupMember. #361

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Implement the removal of NextHopGroup and NextHopGroupMember. #361

merged 5 commits into from
Feb 22, 2024

Conversation

guoshiuan
Copy link
Collaborator

Implements RemoveNextHopGroup() and RemoveNextHopGroupMember().

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8012225930

Details

  • -7 of 55 (87.27%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 2.604%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/dplanerc/routes.go 0 2 0.0%
dataplane/saiserver/routing.go 48 53 90.57%
Totals Coverage Status
Change from base Build 7981756597: 0.005%
Covered Lines: 16928
Relevant Lines: 649956
💛 - Coveralls

DanG100
DanG100 reviewed Feb 22, 2024
View reviewed changes
dataplane/saiserver/routing_test.go Outdated Show resolved Hide resolved
dataplane/saiserver/routing.go Outdated Show resolved Hide resolved
dataplane/saiserver/routing_test.go Outdated Show resolved Hide resolved
dataplane/saiserver/routing_test.go Outdated Show resolved Hide resolved
@guoshiuan guoshiuan merged commit 118035d into main Feb 22, 2024
8 of 9 checks passed
@guoshiuan guoshiuan deleted the rmnhg branch February 22, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoshiuan @DanG100