Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fixes for encap #362

Merged
merged 3 commits into from
Feb 23, 2024
Merged

small fixes for encap #362

merged 3 commits into from
Feb 23, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Feb 23, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 8025865730

Details

  • -8 of 40 (80.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 2.618%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/routing.go 10 11 90.91%
dataplane/saiserver/switch.go 18 20 90.0%
internal/binding/binding.go 0 2 0.0%
dataplane/apigen/protogen/protogen.go 1 4 25.0%
Totals Coverage Status
Change from base Build 8012553272: 0.003%
Covered Lines: 17019
Relevant Lines: 650072
💛 - Coveralls

@DanG100 DanG100 merged commit cff01c6 into main Feb 23, 2024
9 checks passed
@DanG100 DanG100 deleted the encap-fixes branch February 23, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan