Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial tun term impl #384

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Initial tun term impl #384

merged 8 commits into from
Mar 22, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Mar 20, 2024

working on test in new PR

@DanG100 DanG100 requested a review from guoshiuan March 20, 2024 21:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8367426139

Details

  • 25 of 153 (16.34%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 2.676%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/switch.go 14 16 87.5%
dataplane/saiserver/routing.go 10 30 33.33%
dataplane/saiserver/tunnel.go 0 106 0.0%
Files with Coverage Reduction New Missed Lines %
sysrib/zapi.go 9 71.5%
Totals Coverage Status
Change from base Build 8351788933: 0.002%
Covered Lines: 17419
Relevant Lines: 651018
💛 - Coveralls

guoshiuan
guoshiuan reviewed Mar 21, 2024
View reviewed changes
dataplane/saiserver/switch.go Outdated Show resolved Hide resolved
dataplane/saiserver/routing_test.go Outdated Show resolved Hide resolved
dataplane/saiserver/tunnel.go Outdated Show resolved Hide resolved
@DanG100 DanG100 merged commit cc64fe0 into main Mar 22, 2024
11 of 12 checks passed
@DanG100 DanG100 deleted the tunterm branch March 22, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan