Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests with debugging. #391

Merged
merged 4 commits into from
Mar 29, 2024
Merged

More tests with debugging. #391

merged 4 commits into from
Mar 29, 2024

Conversation

guoshiuan
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8483629023

Details

  • 31 of 39 (79.49%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 2.702%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/acl.go 31 39 79.49%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/acl.go 3 66.37%
Totals Coverage Status
Change from base Build 8459456013: 0.002%
Covered Lines: 17592
Relevant Lines: 651116
💛 - Coveralls

@guoshiuan guoshiuan requested a review from DanG100 March 29, 2024 00:30
@guoshiuan guoshiuan merged commit a34665a into main Mar 29, 2024
9 of 10 checks passed
@guoshiuan guoshiuan deleted the mymac branch March 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoshiuan @DanG100