Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify remote port mgmt #397

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Simplify remote port mgmt #397

merged 3 commits into from
Apr 11, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Apr 11, 2024

No description provided.

Copy link

github-actions bot commented Apr 11, 2024

Pull Request Test Coverage Report for Build 8654270870

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 39 (48.72%) changed or added relevant lines in 4 files are covered.
  • 49 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 2.734%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/ports.go 0 1 0.0%
dataplane/saiserver/saiserver.go 0 1 0.0%
dataplane/forwarding/fwdport/ports/kernel.go 0 2 0.0%
dataplane/saiserver/hostif.go 19 35 54.29%
Files with Coverage Reduction New Missed Lines %
dataplane/forwarding/fwdport/ports/kernel.go 1 7.08%
bgp/ocgobgp.go 48 72.31%
Totals Coverage Status
Change from base Build 8562288342: 0.01%
Covered Lines: 17808
Relevant Lines: 651345

💛 - Coveralls

@DanG100 DanG100 requested a review from guoshiuan April 11, 2024 18:19
dataplane/standalone/pkthandler/main.go Show resolved Hide resolved
dataplane/saiserver/hostif.go Outdated Show resolved Hide resolved
@DanG100 DanG100 merged commit dcaf621 into main Apr 11, 2024
10 checks passed
@DanG100 DanG100 deleted the hostif-fix branch April 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants