Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL code gen enhancements #439

Merged
merged 3 commits into from
Jun 24, 2024
Merged

ACL code gen enhancements #439

merged 3 commits into from
Jun 24, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Jun 24, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9650525415

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 2.816%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.002%
Covered Lines: 18533
Relevant Lines: 658232
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9650525415

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 2.816%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.002%
Covered Lines: 18533
Relevant Lines: 658232
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9650525415

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 2.816%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.002%
Covered Lines: 18533
Relevant Lines: 658232
💛 - Coveralls

@DanG100 DanG100 requested a review from guoshiuan June 24, 2024 20:25
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9651845619

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.814%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.0%
Covered Lines: 18522
Relevant Lines: 658232
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9651845619

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.814%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.0%
Covered Lines: 18522
Relevant Lines: 658232
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9651845619

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.814%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.0%
Covered Lines: 18522
Relevant Lines: 658232
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9651874590

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 2.815%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.001%
Covered Lines: 18531
Relevant Lines: 658232
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9651874590

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 2.815%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.001%
Covered Lines: 18531
Relevant Lines: 658232
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9651874590

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 2.815%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.001%
Covered Lines: 18531
Relevant Lines: 658232
💛 - Coveralls

guoshiuan
guoshiuan approved these changes Jun 24, 2024
View reviewed changes
dataplane/apigen/ccgen/ccgen.go Show resolved Hide resolved
dataplane/apigen/ccgen/ccgen.go Show resolved Hide resolved
dataplane/apigen/ccgen/ccgen.go Show resolved Hide resolved
dataplane/apigen/protogen/protogen.go Show resolved Hide resolved
dataplane/standalone/sai/common.cc Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9652735266

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.814%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.0%
Covered Lines: 18524
Relevant Lines: 658232
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9652735266

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.814%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.0%
Covered Lines: 18524
Relevant Lines: 658232
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9652735266

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.814%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/protogen/protogen.go 1 4 25.0%
dataplane/apigen/docparser/docparser.go 0 5 0.0%
Totals Coverage Status
Change from base Build 9605495710: 0.0%
Covered Lines: 18524
Relevant Lines: 658232
💛 - Coveralls

@DanG100 DanG100 merged commit 3b41cb0 into main Jun 24, 2024
11 checks passed
@DanG100 DanG100 deleted the udf-codegen branch June 24, 2024 22:02
@DanG100 DanG100 restored the udf-codegen branch June 24, 2024 22:11
@DanG100 DanG100 deleted the udf-codegen branch June 24, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan