Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement L2MC via ACL redirect. #454

Merged
merged 14 commits into from
Jul 19, 2024
Merged

Implement L2MC via ACL redirect. #454

merged 14 commits into from
Jul 19, 2024

Conversation

guoshiuan
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10013079730

Details

  • 137 of 163 (84.05%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 2.851%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/switch.go 18 20 90.0%
dataplane/forwarding/protocol/metadata/metadata.go 1 6 16.67%
dataplane/saiserver/acl.go 1 10 10.0%
dataplane/saiserver/l2.go 116 126 92.06%
Files with Coverage Reduction New Missed Lines %
bgp/gobgp.go 2 41.87%
Totals Coverage Status
Change from base Build 9998422867: 0.02%
Covered Lines: 18777
Relevant Lines: 658562
💛 - Coveralls

@guoshiuan guoshiuan requested a review from DanG100 July 17, 2024 18:13
DanG100
DanG100 reviewed Jul 17, 2024
View reviewed changes
dataplane/saiserver/acl.go Show resolved Hide resolved
dataplane/saiserver/acl.go Outdated Show resolved Hide resolved
dataplane/saiserver/l2.go Outdated Show resolved Hide resolved
dataplane/saiserver/l2.go Outdated Show resolved Hide resolved
dataplane/saiserver/l2.go Outdated Show resolved Hide resolved
dataplane/saiserver/l2.go Show resolved Hide resolved
@DanG100
Copy link
Collaborator

DanG100 commented Jul 17, 2024

can add UT for this?

@guoshiuan
Copy link
Collaborator Author

can add UT for this?

Done

DanG100
DanG100 reviewed Jul 19, 2024
View reviewed changes
dataplane/saiserver/l2.go Show resolved Hide resolved
dataplane/saiserver/l2.go Outdated Show resolved Hide resolved
@guoshiuan guoshiuan merged commit 8e0bf97 into main Jul 19, 2024
11 checks passed
@guoshiuan guoshiuan deleted the acl branch July 19, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoshiuan @DanG100