Add rule that surrounding container of a list must be a different name. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing inconsistencies in openconfig/public that must be fixed if we're to introduce this: ``` ate/openconfig-ate-flow.yang:427 (at ate/openconfig-ate-flow.yang:103): error: Surrounding container of list ingress-tracking has the same name (often this should be the plural version of the list name) ate/openconfig-ate-flow.yang:427 (at ate/openconfig-ate-flow.yang:112): error: Surrounding container of list egress-tracking has the same name (often this should be the plural version of the list name) ate/openconfig-ate-flow.yang:427 (at ate/openconfig-ate-flow.yang:371): error: Surrounding container of list egress-tracking has the same name (often this should be the plural version of the list name) macsec/openconfig-macsec.yang:787 (at macsec/openconfig-macsec.yang:428): error: Surrounding container of list scsa-tx has the same name (often this should be the plural version of the list name) macsec/openconfig-macsec.yang:787 (at macsec/openconfig-macsec.yang:464): error: Surrounding container of list scsa-rx has the same name (often this should be the plural version of the list name) network-instance/openconfig-network-instance.yang:1349 (at mpls/openconfig-mpls-te.yang:1298): error: Surrounding container of list p2p-primary-path has the same name (often this should be the plural version of the list name) ```
|
In particular this rule will support exception point#2 for struct names in openconfig/ygot#755 |
|
Will close this since no longer pursing this. Autocomplete will help with typing out the names of longer uncompressed structs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing inconsistencies in openconfig/public that must be fixed if we're to introduce this:
This change will enable a more user-friendly compressed name for uncompressed GoStructs.