Restore NONE as an enum value for typedef community-type #1177
+69
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No major YANG version changes in commit 0426df8 |
rszarecki
suggested changes
Sep 7, 2024
s19nal
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
as discussed at OC operators meeting - removing a deprecated status from one enum in the leaf looks to be ok although it might be slightly contentious to call it non-breaking.
However re-instating the deprecated NONE enum solves the problem that was introduced by removing it in the first place, so I'm happy :)
|
Last call for Sep 20, 2024 |
|
@dplore, thanks for resolving this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #945
Change Scope
In the current OC models, there is ambiguity regarding how to use send-community-type to disable sending any communities at the bgp global, peer-group and neighbor levels. The OC model description says the lack of the
send-community-typenode means communities should not be sent. This is in conflict with the expected inheritance from global, peer-group and neighbor levels in BGP configuration. With inheritance, the lack of a node means to inherit the configuration from the next higher level.It was proposed in #945 that an explicitly defined send-community-type as an empty list could be used to indicate no communities should be sent. But this is problematic for some encodings and likely toolchains because RFC7590 states that XML encoded yang simply omits empty lists (ref).
This proposal removes the deprecated status from the
NONEvalue of thecommunity-typeenum.