Adding glome key version and console state. #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
No major YANG version changes in commit 6395898 |
|
@morrowc could you give a review? |
dplore
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Hi, need to bump the version and reference here: https://github.com/openconfig/public/pull/1178/files#diff-6542718fbe869ecef8de06948a5973b627fdf3ff7de2f047bc7ccd4349c9e940R42-R50
|
Done. |
morrowc
approved these changes
Sep 11, 2024
|
"This branch is out-of-date with the base branch" - I suspect a git sync/merge is necessary before submit. |
|
Done. Branch is in sync, save for my changes. |
|
/gcbrun |
dplore
reviewed
Sep 12, 2024
|
/gcbrun |
dplore
reviewed
Sep 12, 2024
Co-authored-by: Darren Loher <[email protected]>
|
/gcbrun |
|
/gcbrun |
dplore
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Scope
There are no implementations yet.