Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transceiver module temp thresholds #948

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add transceiver module temp thresholds #948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion release/models/platform/openconfig-platform-transceiver.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,13 @@ module openconfig-platform-transceiver {
specify a physical-channel within a TRANSCEIVER component
(i.e. gray optic) that it is associated with.";

oc-ext:openconfig-version "0.12.0";
oc-ext:openconfig-version "0.13.0";

revision "2023-08-30" {
description
"Add transceiver module temperature thresholds";
reference "0.13.0";
}

revision "2023-06-27" {
description
Expand Down Expand Up @@ -843,6 +849,22 @@ module openconfig-platform-transceiver {
}
units volts;
}
leaf module-temperature-lower {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any significance to "module" here? Can this just be temperature-low and temperature-high?

Copy link
Member Author

@dplore dplore Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used module-temperature-* to differentiate from laser-temperature-*. Another wording that was considered was 'case-temperature'. It seems like temperature-* may be ambiguous since we are starting to see multiple temperature sensors on some transceiver modules (notably laser-temperature). @ejbrever for any additional comments.

type decimal64 {
fraction-digits 1;
}
units celsius;
description
"The lower temperature threshold for the transceiver module.";
}
leaf module-temperature-upper {
type decimal64 {
fraction-digits 1;
}
units celsius;
description
"The upper temperature threshold for the transceiver module.";
}
}

grouping port-transceiver-top {
Expand Down
Loading