clarification for allow_aggregation control #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarification on control associated with allow_aggregation
…w-aggregation Update gnmi-specification.md
robshakir
approved these changes
Jun 21, 2022
| configuration of the gNMI service. Additionally, a target SHOULD provide means | ||
| sensitive to the latency introduced by bundling, the target MUST follow the | ||
| `SubscriptionList` fields in [Section 3.5.1.2](#3512-the-subscriptionlist-message) | ||
| that indicate if `allow_aggregation` is permitted. |
There was a problem hiding this comment.
I think that maybe we need a larger change to the wording here. I think we should clarify what bundling means here vs. aggregation. Specifically, we were trying to give guidance here as to how many update messages there were per notification.
In aggregation, I think we are looking at how many leaves per update there are. i.e., without allow_aggregation this should be 1.
I'd propose we make this clarification, and then add some text as to when aggregation is triggered. WDYT?
|
When allow aggregation is set in the SubscriptionList how does the model (schema) know where to aggregate? An explanation on how it is referenced in the models would help in the specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clarification for allow_aggregation control