change go minimum version in README #4416
Conversation
| #### Go | ||
|
|
||
| NOTE: if building with Go 1.22.x, make sure to use 1.22.4 or a later version | ||
| (see [issue #4233](https://github.com/opencontainers/runc/issues/4233) for | ||
| more details). | ||
|
|
There was a problem hiding this comment.
To other reviewers: this is no longer needed since PR #4407.
There was a problem hiding this comment.
Should i change 1.22.4 to 1.22 in my changes?
There was a problem hiding this comment.
IMHO just removing this is fine. I think @kolyshkin was just giving context to other reviewers on why removing that note seems fine.
|
Nah, there's something wrong with cache restoration logic in actions/bats-setup |
Resolved in #4412 |
kolyshkin
force-pushed
the
change_version
branch
from
d274c2f
to
f62ec98
Compare
Merged, rebased this one. |
|
Hi @kolyshkin nothing has been removed, and bats was never part of the image AFAIK. Make sure any cache keys you use are unique between actuated/hosted runners as permissions, users and paths may vary - so a cache tar taken from a hosted runner may not restore exactly as expected onto an self-hosted runner and visa-versa. Let me know if I can help Calyptia and Fluent both use bats extensively with actuated and I'm not aware of any issues from them. They may not have the cache option enabled for bats? |
My bad, I mixed things up and mentioned you too early. The issue was in us starting to use https://github.com/bats-core/bats-action, which lacked the arch in cache key, so caches for different archtitectures got mixed. This was promptly reported and fixed by @akhilerm. Again, thank you so much for allowing runc to use Actuated; it's great and invaluable addition to GitHub Actions. |
README.md
Outdated
| @@ -27,16 +27,10 @@ A third party security audit was performed by Cure53, you can see the full repor | |||
|
|
|||
| ## Building | |||
|
|
|||
| `runc` only supports Linux. It must be built with Go version 1.21 or higher. | |||
| `runc` only supports Linux. It must be built with Go version 1.22.4 or higher. | |||
There was a problem hiding this comment.
Now that go enforces the go version in go.mod, don't we want to just delete the last sentence here?
There was a problem hiding this comment.
I think it's fine as it is.
| #### Go | ||
|
|
||
| NOTE: if building with Go 1.22.x, make sure to use 1.22.4 or a later version | ||
| (see [issue #4233](https://github.com/opencontainers/runc/issues/4233) for | ||
| more details). | ||
|
|
There was a problem hiding this comment.
IMHO just removing this is fine. I think @kolyshkin was just giving context to other reviewers on why removing that note seems fine.
|
Please squash the commits |
Signed-off-by: Amir M. Ghazanfari <[email protected]> Update go version Co-authored-by: Akihiro Suda <[email protected]> Signed-off-by: Amir M. Ghazanfari <[email protected]>
amghazanfari
force-pushed
the
change_version
branch
from
ac6b145
to
bb2bd38
Compare
| @@ -27,16 +27,10 @@ A third party security audit was performed by Cure53, you can see the full repor | |||
|
|
|||
| ## Building | |||
|
|
|||
| `runc` only supports Linux. It must be built with Go version 1.21 or higher. | |||
| `runc` only supports Linux. See the header of [`go.mod`](./go mod) for the required Go version. | |||
There was a problem hiding this comment.
This was changed. If we are going to have some text, the text before seem better. But I'm fine with this.
@kolyshkin what do you think? You weighted on this before.
In the readme there are two statements
when i use go v1.21 in Dockerfile for testing I got error
but with go v1.22 and v1.23 it was ok. so i change minimum version to 1.22.4 and delete the warning