validation: test validation test with an empty hostname #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangchenye
reviewed
May 24, 2018
validation/hostname.go
Outdated
| t.Skip(1, fmt.Sprintf("linux-specific namespace test")) | ||
| } | ||
|
|
||
| if err := testHostname(t, false); err != nil { |
There was a problem hiding this comment.
Change these two tests to one loop?
|
+1 for wrapping the testing code, it is good way to solve |
dongsupark
force-pushed
the
dongsu/test-empty-hostname
branch
from
09e2df1
to
582a909
Compare
Check if the hostname test works also with an empty hostname, i.e, `hostname == ""`. Also print out TAP results. Signed-off-by: Dongsu Park <[email protected]>
|
@liangchenye Done. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the hostname test works also with an empty hostname, i.e,
setHostname == false.Also print out TAP results.
Signed-off-by: Dongsu Park [email protected]