Skip to content

distribution: Change from blame to rendered URI for image-index #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wking
Copy link
Contributor

@wking wking commented Mar 6, 2018

We only need blame views when the Markdown does not provide a specific-enough anchor, and this is a link to the whole file.

Fixes the issue raised be @stevvooe here.

We only need blame views when the Markdown does not provide a
specific-enough anchor, and this is a link to the whole file.

Signed-off-by: W. Trevor King <[email protected]>
@dmcgowan
Copy link
Member

dmcgowan commented Mar 7, 2018

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wking
Copy link
Contributor Author

wking commented Mar 12, 2018

@caniszczyk, did you want to merge this before the distribution vote hits its stride?

@stevvooe
Copy link
Contributor

LGTM

@stevvooe stevvooe merged commit e07b90e into opencontainers:add-distribution-proposal Mar 14, 2018
@wking wking deleted the distribution-image-index-blame branch April 4, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants