-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support to custom pricing configuration in helm chart #109
adding support to custom pricing configuration in helm chart #109
Conversation
This looks like it duplicates the efforts of #107. Could you check that patch and see if there's anything in it this one needs? I do like this patch's use use of |
The metricsConfigs.disabledMetrics is necessary to avoid duplicate KMS v2 metrics. But the configmap mounted can be used to mount |
@mattray From what I saw in his PR it tackles different issues with metrics configuration related to state referenced in here and here correct me if I am wrong @tamalsaha, but not custom pricing configuration for on-premise setup. But I'd be happy to include anything that you think relevant in his PR in my changes |
@HoussemCharf, yes. My pr tackles unrelated issues. Those are not related to onpremises deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea of simplifying the barrier for using custom pricing. Thank you for the suggestion and taking a stab at it!
I've made a few comments. Once addressed we can get this merged.
… on-premise setups. Closes opencost#108
@toscott Thanks for your review I've addressed the issues mentioned. |
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last round of changes appears to be working well! Thanks for the contribution @HoussemCharf. Waiting on the CI flows to finish and I'll get this merged.
Closes #108