-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial import of the WIP from https://github.com/prometheus-community/helm-charts/pull/3872 #132
Conversation
7428b73
to
314e345
Compare
Fixes #128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading through the comments on the prometheus-community helm chart pull request, I'm a little confused on what we are trying to accomplish with this. I would expect the home url monotek was referencing to point to the source application that the community helm chart is installing, not another helm chart. I would expect to just set that to:
https://github.com/opencost/opencost
charts/prometheus-opencost-exporter/tmp/prometheus-opencost-exporter/Chart.yaml
Outdated
Show resolved
Hide resolved
I guess just other opinions - I don't think that this necessarily fits into the prometheus-XXX-exporter model. If OpenCost was a product that did not produce prometheus metrics natively and we built a second tool just for exporting metrics, it would make sense to have a prometheus-opencost-exporter helm chart. Since OpenCost exports metrics natively, I don't think we need a new helm chart? |
Signed-off-by: Matt Ray <[email protected]>
…orter Signed-off-by: Matt Ray <[email protected]>
Signed-off-by: Matt Ray <[email protected]>
0409157
to
b12d63e
Compare
@toscott I'm don't have a good understanding what they want in the Prometheus Community hosted version of the chart. I'm happy to make that the only location for it and change it to https://github.com/opencost/opencost and close this out. I think it belongs in the prometheus-XXX-exporter model because some folks only use OpenCost as a metric exporter and don't use the UI at all. https://www.opencost.io/docs/integrations/opencost-exporter I'll try to get some more clarity on their side what they're looking for, this can wait. |
Based on other charts in that repository, I think specifically what they were after on the other PR for the "home" field was a link to the underlying application code of the exporter: e.g. https://github.com/opencost/opencost.
Obviously up to you. Personally I'd think we wouldn't want to try to maintain two separate helm charts, but rather a single helm chart and just make sure its straightforward to use it with a disabled UI component. (This is actually how we are using it at my company already). I suspect splitting off a new helm chart will also split up community involvement between the two and result in inconsistent feature support between the charts. |
The Prometheus OpenCost Exporter Helm chart needs a primary source.