Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in image.tag default values #234

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix typo in image.tag default values #234

merged 1 commit into from
Nov 1, 2024
+3 −3

Conversation

verdel
Copy link
Contributor

@verdel verdel commented Nov 1, 2024 •
edited
Loading

  • Return @ before sha256 in opencost.image.tag and opencost.ui.image.tag
  • Fix sha256 hashes

This fixes #233

@verdel verdel marked this pull request as draft November 1, 2024 00:15
@verdel
fix: typo in image.tag default values
8bc2bed 
Signed-off-by: Vadim Aleksandrov <[email protected]>
@verdel verdel force-pushed the fix-typo-in-image-tag branch from f5cecc7 to 8bc2bed Compare November 1, 2024 00:16
@verdel verdel marked this pull request as ready for review November 1, 2024 00:18
mkilchhofer
mkilchhofer approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I encountered the same issue with the chart update 1.42.0 -> 1.42.1

@rkashasl
Copy link

rkashasl commented Nov 1, 2024

When the new version would be released? Renovate autoupdated opencost as it was a patch version update and now it doesn't work everywhere

@toscott toscott self-assigned this Nov 1, 2024
toscott
toscott approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@toscott toscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdel - Thank you for correcting this!

@toscott toscott merged commit aed7c90 into opencost:main Nov 1, 2024
1 check passed
asdfgugus

This comment was marked as outdated.

Sign in to view

@verdel verdel deleted the fix-typo-in-image-tag branch November 2, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdfgugus asdfgugus asdfgugus approved these changes

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@toscott toscott toscott approved these changes

Assignees

@toscott toscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in image.tag in chart version 1.42.1
5 participants
@verdel @rkashasl @toscott @mkilchhofer @asdfgugus