Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterrole.yaml: add if condition for .Values.rbac.enabled #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kastl-ars
Copy link

clusterrole.yaml: add if condition for .Values.rbac.enabled, like on the clusterrolebinding

fix #241

…ues.rbac.enabled, like on the clusterrolebinding

fix opencost#241
@mittal-ishaan
Copy link
Contributor

Hi @kastl-ars
Thank you for this. LGTM
Due to my recent merge, we did add rbac like this which we would want to consider upon. My bad here, I should have seen it under my PR.
Should we also have them under this if condition too, we are already gating them under a helm config?

Question is do we also want to have rbac.enabled flag gate the cluster role needed in openshift environment too (that looks exactly what this flag is intended to do) or we can have scenarios where a user wants to disable the rbac.enabled flag but want the required cluster role, etc for openshift environment.

Otherwise the Issue raised and PR is really helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of ClusterRole and Clusterrolebindings cannot be disabled
2 participants