Add ITs for CPUCoreLimitAverage/RAMBytesLimitAverage #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'll let @Manas23601 that the first pass, then will have a look too! |
Collaborator
|
LGTM, great job !!! |
Collaborator
|
@ameijer , can you take a look now? |
Contributor
Author
|
@Manas23601 would you be able to advise on the failures in the GHA tests? Any idea what might be going on? |
Collaborator
|
I'll take a look at it today |
Collaborator
|
@ameijer , do you know what is causing this bug? I see negative GPU costs ?
|
Member
|
@Manas23601 might be a flake. I am re-running tests now |
ameijer
approved these changes
Nov 12, 2025
Member
|
@biancaburtoiu can you merge from main? i think that should fix the last failing test |
Member
|
never mind, I was able to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opencost: opencost/opencost#3421