-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add qr validation #11
base: develop
Are you sure you want to change the base?
Conversation
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
|
||
import { birthEvent } from './index' | ||
|
||
// @TODO: remove this skip | ||
test.skip('birth configuration is parsed', async () => { | ||
test('birth configuration is parsed', async () => { | ||
expect(birthEvent).toMatchSnapshot() | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this diff specific to MOSIP or should it be added to countryconfig as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I pulled countryconfig, this test was failing for missing snapshot. So I marked it skip. but now while I checked in countryconfig repo, I see the snapshot is pushed there
src/form/common/id-reader-fields.ts
Outdated
export const iDReaderFields = ( | ||
event: 'birth' | 'death', | ||
section: 'informant' | 'mother' | 'father', | ||
conditionals: Conditional[] = [] | ||
) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this as a whole could be in @opencrvs/mosip/packages/country-config going forward but we can move it separately
src/form/common/id-reader-fields.ts
Outdated
export const getInitialValueFromIDReader = (fieldNameInReader: string) => ({ | ||
dependsOn: ['idReader', 'esignetCallback'], | ||
expression: `$form?.idReader?.${fieldNameInReader} || $form?.esignetCallback?.data?.${fieldNameInReader} || ""` | ||
}) | ||
|
||
export const iDReaderFields = ( | ||
event: 'birth' | 'death', | ||
section: 'informant' | 'mother' | 'father', | ||
conditionals: Conditional[] = [] | ||
) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naftis now that I added one more function, would it make sense if I move all these to mosip/country-config package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the design principle as keeping opencrvs-countryconfig-mosip as similar as possible to opencrvs-countryconfig (for easy conflict management for countries, easy integration)
So I would say your suggestion supports this design yes :P
If and when we need to change these functions in following releases, it's easier for countries to just bump the version number than to fix the conflicts
No description provided.