feat: Map qualified_relations onto dataset #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarusarah
reviewed
Oct 6, 2023
| @@ -717,6 +733,32 @@ def graph_from_dataset(self, dataset_dict, dataset_ref): # noqa | |||
| Literal(reference_identifier) | |||
| )) | |||
|
|
|||
| if dataset_dict.get("qualified_relations"): | |||
There was a problem hiding this comment.
Short question: What is best practice in python: single or double question marks? Could we add this for linting?
There was a problem hiding this comment.
There isn't a single accepted practise (although we should be consistent, which I realise this is not). When we upgrade to Python 3, we can start using Black for linting, which requires double quotes.
sarusarah
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.