Skip to content

Commit

Permalink
Merge pull request #11 from vsaw/tmp-docs-github-action
Browse files Browse the repository at this point in the history
docs(GitHub): Publish on Master
  • Loading branch information
vsaw authored Jan 15, 2021
2 parents 07568b7 + a039aa3 commit d0b16ac
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,11 @@ on:

jobs:
# Build docker images
#
# TODO: Publish docker images to dockerhub on changes in the development branch.
# We won't push major releases. But development previews are fine.
build-docker-and-publish:
runs-on: ubuntu-latest
# needs: build-and-test-code
env:
# Only publish to Docker Hub if we have a change in the development branch
# Publish to Docker Hub if we have a change in the development or master branch
DOCKERHUB_PUBLISH: ${{ github.event_name == 'push' && (github.event.ref == 'refs/heads/development' || github.event.ref == 'refs/heads/master') && secrets.DOCKERHUB_USERNAME != '' }}
# In case we run a pull request, the secrets are not available to us. Therefore check first
# and assign a 'dummy' dockerhub username
Expand Down

0 comments on commit d0b16ac

Please sign in to comment.