-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tracker to be class based + Add types #48
base: master
Are you sure you want to change the base?
Conversation
@vsaw hope you review it and merge it to the new release if everything is ok, |
@JooZef315 could you make a fork of it instead? I doubt it will be merged here |
It is already forked. If you want to use the fork you may use it with |
Sorry, I'm maintaining ODC and this Library as a hobby and got caught up in my day job. That being said I would like to merge this PR but don't have the time to fully review it therefore let me ask you a few questions and hopefully we can push through this way
|
1- the breaking change now is that to use the tracker we have to make an instance of it firstimport { Tracker } from 'node-moving-things-tracker';
const tracker = new Tracker();
tracker.updateTrackedItemsWithNewFrame(detectionScaledOfThisFrame, currentFrame);
const trackerDataForThisFrame = tracker.getJSONOfTrackedItems(); 2- YES, it uses the ODC Code StyleI used the linter to check and it passes well. 3- No Breaking changes in the updated librariesonly |
@JooZef315 Is there a way to keep it backwards compatible? E.g. by having a static default instance that will be used if people don't create separate instances? |
issue: #47
This pull request includes: